-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Re-initialize WXT modules correctly during development #1176
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wxt.config.ts
file changes during development
@wxt-dev/auto-icons
@wxt-dev/module-solid
@wxt-dev/module-react
@wxt-dev/module-svelte
@wxt-dev/i18n
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
wxt
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 80.65% 80.34% -0.31%
==========================================
Files 127 127
Lines 6033 6066 +33
Branches 1016 1019 +3
==========================================
+ Hits 4866 4874 +8
- Misses 1152 1177 +25
Partials 15 15 ☔ View full report in Codecov by Sentry. |
This close #857, #863, #939.
There were lots of callbacks and dependencies between variables in the
createServer
function... I was able to clean it up apart of this PR! Very happy about that, wasn't sure how I would work around that...I don't have E2E tests for dev mode, so we'll need to check over this carefully.
Todo
modules/*
is saved during development, not just whenwxt.config.ts
is changedbuild:manifest
calls #863wxt.config
viawxt.hook
is reset on dev reloaded #939