Don't allow filenames >8chars to save to 4.22 format.

Also don't default filenames to echo tags if they are over
8 chars in size.

Fixes #1306

(cherry picked from commit b294a7c)

bbs/subedit.cpp

@@ -333,8 +333,9 @@ static void modify_sub(int n) {
         if (a()->subs().sub(n).name == "** New WWIV Message Sub **") {
           a()->subs().sub(n).name = a()->subs().sub(n).desc;
         }
-        if (a()->subs().sub(n).filename == "NONAME") {
-          a()->subs().sub(n).filename = a()->subs().sub(n).nets[0].stype;
+        const auto stype = a()->subs().sub(n).nets[0].stype;
+        if (a()->subs().sub(n).filename == "NONAME" && stype.size() <= 8) {
+          a()->subs().sub(n).filename = stype;
         }
       } else if (ch2 == 'D' || ch2 == 'M') {
         bout.nl();

sdk/subxtr.cpp

@@ -325,11 +325,18 @@ bool Subs::Save() {
   std::vector<xtrasubsrec> xsubs;
 
   for (const auto& s : subs_) {
-    subboardrec_422_t ls = {};
-    xtrasubsrec lx = {};
-    to_char_array(ls.name, s.name);
-    to_char_array(lx.desc, s.desc);
-    to_char_array(ls.filename, s.filename);
+    // Only copy over what data fits in the old format.
+    subboardrec_422_t ls{};
+    xtrasubsrec lx{};
+    if (s.name.size() < sizeof ls.name) {
+      to_char_array(ls.name, s.name);
+    }
+    if (s.desc.size() < sizeof lx.desc) {
+      to_char_array(lx.desc, s.desc);
+    }
+    if (s.filename.size() < sizeof ls.filename) {
+      to_char_array(ls.filename, s.filename);
+    }
     ls.key = s.key;
     ls.readsl = s.readsl;
     ls.postsl = s.postsl;