Eliminate session key #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the main key can be easily rotated, the session key is no longer needed as we can simply rotate the main key whenever we make a change to the encrypted data.
This was referenced Aug 8, 2024
Merged
|
I will also update the encryption architecture docs (see also wwWallet/wallet-docs#8 which is still pending) to reflect this change. |
kkmanos
approved these changes
Aug 9, 2024
|
Documentation PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in the self-critique of the v3 encryption architecture: Now that the main key can be easily rotated, the session key is no longer needed as we can simply rotate the main key whenever we make a change to the encrypted data. Eliminating the session key simplifies this key rotation on updating the encrypted data.
This depends on: