Remove Tuist support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@g-mark I noticed there are 7 build-and-test jobs running now. Will this be the case for all PRs going forward? That seems a little excessive right? |
It's the only way to test broad coverage of various Swift versions. Lasso supports as low as Swift 4.2! I don't know (I doubt) if any one in the community is relying on that level of support, but it would seem arbitrary to remove it just so we have fewer CI jobs running. Since updates to Lasso are infrequent, this should be ok. |
AlanK
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest versions of Tuist (4.x) are able to work with Lasso as a Swift Package, so we can remove this support from the repo.
The idea was brittle anyway, since the Product.swift file was dependent on a specific version of Tuist, and if the consuming project (i.e., WW) wasn't using the exact same version of Tuist there could be problems.
This PR: