Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add subgraph access logs #1401

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: add subgraph access logs #1401

wants to merge 9 commits into from
+735 −150

Conversation

df-wg
Copy link
Contributor

@df-wg df-wg commented Nov 26, 2024

Motivation and Context

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@df-wg df-wg force-pushed the dave/eng-6016-subgraph-access-logs branch from 9d1c2fa to fc933b4 Compare November 26, 2024 17:08
@df-wg df-wg mentioned this pull request Nov 27, 2024
Open
StarpTech
StarpTech requested changes Nov 28, 2024
View reviewed changes
router/internal/requestlogger/requestlogger.go Outdated Show resolved Hide resolved
router/pkg/config/config.schema.json Show resolved Hide resolved
router/internal/requestlogger/subgraphlogger.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that we have covered the most important paths in unit tests.

@df-wg df-wg force-pushed the dave/eng-6016-subgraph-access-logs branch from 978b1ed to e18d81f Compare November 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@df-wg @StarpTech