-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluginize Persisted Operations #1277
Conversation
Hi @janeli1, Thank you for the PR! As a general practice, new features should be discussed in an issue before implementation. This allows us to better understand the reasoning behind them and ensure alignment with the overall direction of the project. For instance, I'm not entirely sure how your proposed additions would be used and what problem they exactly solving. To help move things forward, could you please separate the fix from the new features and open an issue to discuss them? Apologies for any confusion this process will be made clearer in the future as we plan to improve the PR template. At the same time, we're currently working on an extensive overhaul of the module system RFC , and I'd appreciate your input on how we might address the points you've included in this PR. |
Sure,
|
I have opened new feature request in #1278 and discussed the reasoning behind this change. |
@@ -0,0 +1,65 @@ | |||
package clientinfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just make the package client
and the interfaces Info
and Token
?
@@ -664,7 +670,7 @@ type WebSocketConnectionHandler struct { | |||
request *http.Request | |||
conn *wsConnectionWrapper | |||
protocol wsproto.Proto | |||
clientInfo *ClientInfo | |||
detailedClientInfo clientinfo.DetailedClientInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave this field name as clientInfo
? Then with the interface as client.Info
.
Closed this pull request. As discussed, I will 1) create another pull request for cache logic fix; 2) create a new pull request only contains logic for 1278 |
Motivation and Context
This pull request is to pluginize Persisted Operations.