PAC with claim #114
Merged
PAC with claim #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 things:
|
# Conflicts: # library/src/main/java/com/wultra/android/mtokensdk/operation/PACUtils.kt
…imDetailData` so it better suits for both requests. Pass the result of request directly without adding it to the operations list
kober32
requested changes
Jan 5, 2024
library/src/main/java/com/wultra/android/mtokensdk/operation/IOperationsService.kt
Outdated
Show resolved
Hide resolved
kober32
previously approved these changes
Jan 9, 2024
kober32
approved these changes
Jan 9, 2024
Hopsaheysa
added a commit
that referenced
this pull request
Jul 31, 2024
* #107 - change `TOTPUtils` to `PACUtils` and update format to handle JWTs but also deeplinks * #111 - implement claim and detail endpoints * Fix detail and claim endpoints, rename request class to `OperationClaimDetailData` so it better suits for both requests. Pass the result of request directly without adding it to the operations list * Add Integration tests for getDetail and claim * Add docs for claim and getDetail * Fix ktlint * Fix docs indentation * Fix docs claim indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated and renamed
TOTPUtilsparser toPACUtils#108implemented #111
detailEndpoint
/api/auth/token/app/operation/detailclaimEndpoint
/api/auth/token/app/operation/detail/claim