Fix #484: Final document verification #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banterCZ
force-pushed
the
issues/484-cross-document-verification
branch
from
f724afb
to
edf2393
Compare
banterCZ
changed the title
banterCZ
commented
Nov 4, 2022
...arding-common/src/main/java/com/wultra/app/onboardingserver/common/service/AuditService.java
Show resolved
Hide resolved
...g/src/main/java/com/wultra/app/onboardingserver/docverify/zenid/config/ZenidConfigProps.java
Show resolved
Hide resolved
| final OwnerId ownerId) { | ||
| documentVerifications.forEach(docVerification -> | ||
| auditService.audit(docVerification, "Document accepted at final verification for user: {}", identityVerification.getUserId())); | ||
| identityVerificationService.moveToPhaseAndStatus(identityVerification, DOCUMENT_VERIFICATION_FINAL, ACCEPTED, ownerId); |
There was a problem hiding this comment.
Not introduced as a separate state of state machine configuration yet. Added just for auditing reasons. For sync processing, this step makes sense to be done all at once. Should be added to the diagram.
There was a problem hiding this comment.
I assume this may change with async processing, right?
romanstrobl
approved these changes
Nov 4, 2022
...arding-common/src/main/java/com/wultra/app/onboardingserver/common/service/AuditService.java
Show resolved
Hide resolved
...g/src/main/java/com/wultra/app/onboardingserver/docverify/zenid/config/ZenidConfigProps.java
Show resolved
Hide resolved
| final OwnerId ownerId) { | ||
| documentVerifications.forEach(docVerification -> | ||
| auditService.audit(docVerification, "Document accepted at final verification for user: {}", identityVerification.getUserId())); | ||
| identityVerificationService.moveToPhaseAndStatus(identityVerification, DOCUMENT_VERIFICATION_FINAL, ACCEPTED, ownerId); |
| final OwnerId ownerId) { | ||
| documentVerifications.forEach(docVerification -> | ||
| auditService.audit(docVerification, "Document accepted at final verification for user: {}", identityVerification.getUserId())); | ||
| identityVerificationService.moveToPhaseAndStatus(identityVerification, DOCUMENT_VERIFICATION_FINAL, ACCEPTED, ownerId); |
There was a problem hiding this comment.
I assume this may change with async processing, right?
| @@ -125,9 +125,11 @@ public void processClientEvaluation(final IdentityVerificationEntity identityVer | |||
|
|
|||
| private static String getVerificationId(final IdentityVerificationEntity identityVerification) { | |||
| return identityVerification.getDocumentVerifications().stream() | |||
| .filter(DocumentVerificationEntity::isUsedForVerification) | |||
| .filter(it -> it.getStatus() == DocumentStatus.ACCEPTED) | |||
| .findAny() | |||
There was a problem hiding this comment.
This check is still suboptimal. We rather want to executed findAll(), put all results into a Set and make sure this set has only one item which is the ID of verification we want to use. In case of multiple IDs found, this is a severe error in business logic and we want to abort the processing. I will raise an issue for future improvement request.
...g/src/main/java/com/wultra/app/onboardingserver/docverify/zenid/config/ZenidConfigProps.java
Show resolved
Hide resolved
| reject(identityVerification, result, documentVerifications, ownerId); | ||
| break; | ||
| case IN_PROGRESS: | ||
| throw new DocumentVerificationException("Only sync mode is supported, " + ownerId); |
.../java/com/wultra/app/onboardingserver/impl/service/document/DocumentVerificationService.java
Outdated
Show resolved
Hide resolved
| .map(DocumentVerificationEntity::getUploadId) | ||
| .collect(toList()); | ||
|
|
||
| final DocumentsVerificationResult result = documentVerificationProvider.verifyDocuments(ownerId, uploadIds); |
There was a problem hiding this comment.
In case of an error during verifyDocuments call the identity verification may get stuck in this phase/status. Let's raise a ticket for handling this separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.