2.0 #15
Open
2.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated python files and documentation files by moving python files to the folder 'neurec'.
Moved NeuRec.properties file to conf folder.
Refactored reading of files due to project being converted into a package and not knowning the path to the package. Configuration and dataset files are now read in the neurec/util/reader module, using importlib_resources.
Establish the first set of documentation, including: 1. Installation 2. Get Started 3. Custom Model
- Added file handler for logging to a file - Replaced print statements with logging.info in models - Set logger to root to show log output in Jupyter notebook
- Changed python packages to install from requirements.txt file - Corrected base image tags - Installed python 3.6
- Updated dockerfiles with neurec python package - Updated docs with docker image location - Add manifest file to add datasets to python package - Added init file for modules - Updated setup file with necessary details
NeuRec 1.0 packaging
Updated documentation: - Updated 1. Installation with Github docker instructions - Updated 2. Get Started with the latest settings and output - Updated 3. Properties with the latest settings - Added section on sequential and social models for 4. Custom Model Improved properties functionality: - Added ability to provide a list of conversions for a property value - Optimised by performing conversion when loading the properties, rather than when reading a property - Set recommender value to a lower case string Updated python package details with the following: - Update version number to 2.0.0 - Added README.md file as the long description - Added package dependencies
wubinzzu
approved these changes
Nov 7, 2019
wubinzzu
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prepares NeuRec 2.0 for packaging. In contains changes to the structure of the project, documentation, and enhancements to improve interaction when used as an imported package.