TV Panel Scaffold #260

josephom12 · 2019-10-09T04:25:43Z

This PR includes routing for the TV panel at /tvpanel and base components for tvpanel, Map, Header, ETAs and News.

Builds the front-end scaffold to implement:

ETA functionality
News functionality

Note: I'm unsure on how to fix those CI errors.

codecov · 2019-10-09T04:25:48Z

Codecov Report

Merging #260 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #260      +/-   ##
=========================================
+ Coverage   37.45%   37.5%   +0.04%     
=========================================
  Files          17      17              
  Lines        1559    1560       +1     
=========================================
+ Hits          584     585       +1     
  Misses        911     911              
  Partials       64      64

Impacted Files	Coverage Δ
api/api.go	`80.73% <100%> (+0.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af012aa...8a00a6b. Read the comment docs.

quuu

Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page

Otherwise, good starting design with the side bar

josephom12 · 2019-10-09T18:58:05Z

Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page

Otherwise, good starting design with the side bar

Banner on the bottom

quuu · 2019-10-09T19:00:11Z

Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page
Otherwise, good starting design with the side bar

Banner on the bottom

When i said redundant, I meant how you have both "Shuttle Tracker" and the URL both in the same bar

josephom12 · 2019-10-09T19:02:48Z

Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page
Otherwise, good starting design with the side bar

Banner on the bottom

When i said redundant, I meant how you have both "Shuttle Tracker" and the URL both in the same bar

LOOOL oh gotcha!

Here's another variation just in case it appeals to you before I start moving the names.

quuu · 2019-10-09T19:12:06Z

LOOOL oh gotcha!

Here's another variation just in case it appeals to you before I start moving the names.

Leave it for now, build out the rest of the UI and then we'll ask others what they think of it as well.

josephom12 · 2019-11-10T07:12:27Z

Looking at the console of the TV Panel, I see an error that says:

When I go to localhost:8080/fusion, I get the error:

Did I miss something or is this error popping up because I'm running it on my machine? I don't seem to get these errors when I run localhost:8080 though.. thoughts?

@quuu @IncognitoCactus @evanlazaro

josephom12 · 2019-11-16T20:09:57Z

I have a question! @evanlazaro @quuu @IncognitoCactus

Is using fusion necessary for the TV panel? I'm not exactly sure what fusion does but does it have any impact on the main application? (Besides the bus-button)

If anyone knows what exactly fusion/websocket does in this application, please let me know!

- Added placeholders and styling for ETAs and news articles.

…isplayed (i.e. blue for West, green for East) to match the map

houndci-bot · 2019-11-19T22:14:12Z

api/api.go

@@ -1,3 +1,213 @@
+<<<<<<< HEAD


expected 'package', found '<<'

houndci-bot · 2019-11-19T22:14:13Z

api/api.go

@@ -1,3 +1,213 @@
+<<<<<<< HEAD


expected 'package', found '<<'

houndci-bot · 2019-11-19T22:14:14Z

api/routes.go

+	WriteJSON(w, stop)
+}
+
+func (api *API) StopsDeleteHandler(w http.ResponseWriter, r *http.Request) {


exported method API.StopsDeleteHandler should have comment or be unexported

houndci-bot · 2019-11-19T22:14:14Z

api/vehicles.go

+	}
+}
+
+func (api *API) VehiclesDeleteHandler(w http.ResponseWriter, r *http.Request) {


exported method API.VehiclesDeleteHandler should have comment or be unexported

houndci-bot · 2019-11-19T22:14:15Z

api/vehicles.go

+	}
+}
+
+func (api *API) VehiclesEditHandler(w http.ResponseWriter, r *http.Request) {


exported method API.VehiclesEditHandler should have comment or be unexported

houndci-bot · 2019-11-19T22:14:15Z

api/routes.go

+	WriteJSON(w, stop)
+}
+
+func (api *API) StopsDeleteHandler(w http.ResponseWriter, r *http.Request) {


exported method API.StopsDeleteHandler should have comment or be unexported

houndci-bot · 2019-11-19T22:14:16Z

eta/eta.go

+const earthRadius = 6371000.0 // meters
+
+// ETAManager implements ETAService and provides ETAs for Vehicles to Stops.
+type ETAManager struct {


type name will be used as eta.ETAManager by other packages, and that stutters; consider calling this Manager

houndci-bot · 2019-11-19T22:14:16Z

api/vehicles.go

+	}
+}
+
+func (api *API) VehiclesDeleteHandler(w http.ResponseWriter, r *http.Request) {


exported method API.VehiclesDeleteHandler should have comment or be unexported

houndci-bot · 2019-11-19T22:14:17Z

api/vehicles.go

+	}
+}
+
+func (api *API) VehiclesEditHandler(w http.ResponseWriter, r *http.Request) {


exported method API.VehiclesEditHandler should have comment or be unexported

houndci-bot · 2019-11-19T22:14:25Z

updater/updater.go

+	return updater, nil
+}
+
+func NewConfig(v *viper.Viper) *Config {


exported function NewConfig should have comment or be unexported

houndci-bot · 2019-11-19T22:14:25Z

updater/updater.go

+	subscribers          []func(*shuttletracker.Location)
+}
+
+type Config struct {


exported type Config should have comment or be unexported

houndci-bot · 2019-11-19T22:14:26Z

log/log.go

+	WithFields(contextFields()).Debug(args...)
+}
+
+func Debugf(format string, args ...interface{}) {


exported function Debugf should have comment or be unexported

houndci-bot · 2019-11-19T22:14:26Z

log/log.go

+	WithFields(contextFields()).Infof(format, args...)
+}
+
+func Debug(args ...interface{}) {


exported function Debug should have comment or be unexported

houndci-bot · 2019-11-19T22:14:26Z

log/log.go

+	WithFields(contextFields()).Info(args...)
+}
+
+func Infof(format string, args ...interface{}) {


exported function Infof should have comment or be unexported

houndci-bot · 2019-11-19T22:14:29Z

log/log.go

+	return logger.WithField(f, v)
+}
+
+func WithFields(f ...Fields) *logrus.Entry {


exported function WithFields should have comment or be unexported

houndci-bot · 2019-11-19T22:14:29Z

log/log.go

+	}
+}
+
+func WithField(f string, v interface{}) *logrus.Entry {


exported function WithField should have comment or be unexported

houndci-bot · 2019-11-19T22:14:29Z

log/log.go

+	return cfg
+}
+
+func SetLevel(level string) {


exported function SetLevel should have comment or be unexported

houndci-bot · 2019-11-19T22:14:30Z

log/log.go

+	Level string
+}
+
+type Fields map[string]interface{}


exported type Fields should have comment or be unexported

houndci-bot · 2019-11-19T22:14:30Z

log/log.go

+	logger *logrus.Logger
+)
+
+type Config struct {


exported type Config should have comment or be unexported

houndci-bot · 2019-11-19T22:14:41Z

frontend/src/assets/vars.scss

+$link: #ff0000;
+$primary-invert: findColorInvert($primary);
+$twitter: #4099ff;
+$twitter-invert: findColorInvert($twitter);


Name of function findColorInvert should be written in all lowercase letters with hyphens instead of underscores

houndci-bot · 2019-11-19T22:14:42Z

frontend/src/assets/vars.scss

+
+$primary: #ed1c24;
+$link: #ff0000;
+$primary-invert: findColorInvert($primary);


Name of function findColorInvert should be written in all lowercase letters with hyphens instead of underscores

houndci-bot · 2019-11-19T22:14:42Z

frontend/src/assets/styles.scss

-  top: 0;
-  width: 100%;
-}
+html,


Rule set contains (11/10) properties

houndci-bot · 2019-11-19T22:14:42Z

frontend/src/admin/js/admin.js

+    return {
+      state: 0,
+      mainStyle: {position: "fixed",width: "auto",right:"0px",top:"50px",height: "auto", overflow: "scroll", bottom: "0",left: "150px"}
+    }


Missing semicolon.

josephom12 marked this pull request as ready for review October 9, 2019 04:35

josephom12 requested review from evanlazaro, zacharylove and quuu October 9, 2019 04:35

quuu suggested changes Oct 9, 2019

View reviewed changes

github in corner

9f89e3e

josephom12 and others added 13 commits November 19, 2019 16:55

Set up routing to /tvpanel and add vue scaffold for the tvpanel

cc28c29

Add TV Panel Wireframe to the assets folder

48553f8

Only display the TabBar in the Public.vue component

aa74040

Add Map component functionality to the tvpanel

c7bb2b1

Add admin message functionality for the Map component

d006f30

CSS adjustments for Map and add Header Component for Map

92d0042

Adjust Map and Header width

8ea518c

Add ETAs and News component scaffolds

50b024e

Placeholders for ETA and News data

afd8fb7

- Added placeholders and styling for ETAs and news articles.

Added the styles for the text color based on which shuttle's ETA is d…

2d4ddac

…isplayed (i.e. blue for West, green for East) to match the map

Updated README with macOS Catalina support

26e9a67

axios get request

19cc5e1

Add Time Display Component

8a5f9ba

houndci-bot reviewed Nov 19, 2019

View reviewed changes

api/api.go Outdated

@@ -1,3 +1,213 @@

<<<<<<< HEAD

Copy link

houndci-bot Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 'package', found '<<'

houndci-bot reviewed Nov 19, 2019

View reviewed changes

api/api.go Outdated

@@ -1,3 +1,213 @@

<<<<<<< HEAD

Copy link

houndci-bot Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 'package', found '<<'

houndci-bot reviewed Nov 19, 2019

View reviewed changes

ericabertolozzi force-pushed the TV-Panel-Fall2019 branch from 06c3e83 to 8a5f9ba Compare November 19, 2019 22:15

josephom12 and others added 2 commits November 22, 2019 16:30

Merge remote-tracking branch 'origin/master' into TV-Panel-Fall2019

e04510d

Fix TimeDisplay error

8a00a6b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TV Panel Scaffold #260

TV Panel Scaffold #260

josephom12 commented Oct 9, 2019 •

edited

Loading

codecov bot commented Oct 9, 2019 •

edited

Loading

quuu left a comment

josephom12 commented Oct 9, 2019

quuu commented Oct 9, 2019

josephom12 commented Oct 9, 2019

quuu commented Oct 9, 2019

josephom12 commented Nov 10, 2019

josephom12 commented Nov 16, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

houndci-bot Nov 19, 2019

TV Panel Scaffold #260

Are you sure you want to change the base?

TV Panel Scaffold #260

Conversation

josephom12 commented Oct 9, 2019 • edited Loading

codecov bot commented Oct 9, 2019 • edited Loading

Codecov Report

quuu left a comment

Choose a reason for hiding this comment

josephom12 commented Oct 9, 2019

quuu commented Oct 9, 2019

josephom12 commented Oct 9, 2019

quuu commented Oct 9, 2019

josephom12 commented Nov 10, 2019

josephom12 commented Nov 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josephom12 commented Oct 9, 2019 •

edited

Loading

codecov bot commented Oct 9, 2019 •

edited

Loading