Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secretName to spec.tls. Closes #294 #295

Closed
wants to merge 1 commit into from
Closed

Conversation

CC007
Copy link

@CC007 CC007 commented Mar 19, 2021

Purpose

Be able to configure a TLS certificate secret in your k8s cluster, based on the wso2is deployment name

Goals

Added secretName to spec.tls property in the ingress config file

User stories

#294

Release note

Added secretName to spec.tls property in the ingress config file, so that you can add a TLS certificate secret to your k8s cluster that will be used for requests to wso2is.

Documentation

N/A. Nothing changes in regards to what the user has to configure

Certification

N/A. This is a very basic kubernetes feature.

Security checks

Samples

This allows you to do this:

sudo kubectl create secret tls wso2is-pattern-1-tls -n <NAMESPACE> --cert="path/to/cert.pem" --key="path/to/key.pem"

Test environment

OS: Windows 10 2020H2 using WSL2 Ubuntu 18.04
K8S: v1.18
kubernetes-is: 5.11.0-3

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021

CLA assistant check
All committers have signed the CLA.

@sahangunathilaka
Copy link

@CC007, Thank you for your contribution on this.

Please note that this is the minimal reference version that we are maintaining simply that everyone can use. There can be multiple changes as you suggested to be done on top of this. We are not planing to add them here but let everyone to take the advantage of making any improvement on top this and use.

Further, we need close the PR as this has been opened for long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants