-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve action execution core #6262
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6262 +/- ##
============================================
+ Coverage 45.72% 45.94% +0.21%
- Complexity 14065 14738 +673
============================================
Files 1633 1667 +34
Lines 100705 105169 +4464
Branches 17706 18380 +674
============================================
+ Hits 46045 48317 +2272
- Misses 47959 49925 +1966
- Partials 6701 6927 +226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1d4b9c8
to
4e32383
Compare
4e32383
to
b0be613
Compare
...tion.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/Incomplete.java
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
2cd2670
to
4b0b14d
Compare
PR builder started |
PR builder completed |
...rc/main/java/org/wso2/carbon/identity/action/execution/ActionExecutionResponseProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/action/execution/impl/ActionExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/identity/action/execution/model/ActionInvocationSuccessResponse.java
Outdated
Show resolved
Hide resolved
...tion.execution/src/main/java/org/wso2/carbon/identity/action/execution/model/Incomplete.java
Outdated
Show resolved
Hide resolved
770a0e3
to
8a19f3c
Compare
d419754
to
9e77095
Compare
9e77095
to
3e04086
Compare
Quality Gate failedFailed conditions |
Issue:
With this PR following improvements will be added to the action exection core.
Add INCOMPLETE action invocation status. Eg: In the custom authentication, the external service will be want to redirect user to custom page. There we can utilize this new INCOMPLETE state with REDIRECT operation.
This will bring the Bring following method which execute the action id list to its interface.