Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action execution core #6262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Jan 6, 2025

Issue:

With this PR following improvements will be added to the action exection core.

  1. Add INCOMPLETE action invocation status. Eg: In the custom authentication, the external service will be want to redirect user to custom page. There we can utilize this new INCOMPLETE state with REDIRECT operation.

  2. This will bring the Bring following method which execute the action id list to its interface.

    ActionExecutionStatus execute(ActionType actionType, String[] actionIdList,
                                  Map<String, Object> eventContext, String tenantDomain)
            throws ActionExecutionException;

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 74.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 45.94%. Comparing base (9148662) to head (3e04086).
Report is 164 commits behind head on master.

Files with missing lines Patch % Lines
...xecution/util/ActionExecutionDiagnosticLogger.java 0.00% 7 Missing ⚠️
...tion/execution/impl/ActionExecutorServiceImpl.java 81.25% 4 Missing and 2 partials ⚠️
...tion/model/ActionInvocationIncompleteResponse.java 66.66% 3 Missing and 3 partials ⚠️
...on/execution/ActionExecutionResponseProcessor.java 0.00% 2 Missing ⚠️
...ity/action/execution/util/OperationComparator.java 0.00% 1 Missing and 1 partial ⚠️
...tion/execution/model/ActionInvocationResponse.java 50.00% 1 Missing ⚠️
...on/identity/action/execution/model/Incomplete.java 75.00% 1 Missing ⚠️
...ntity/action/execution/model/IncompleteStatus.java 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6262      +/-   ##
============================================
+ Coverage     45.72%   45.94%   +0.21%     
- Complexity    14065    14738     +673     
============================================
  Files          1633     1667      +34     
  Lines        100705   105169    +4464     
  Branches      17706    18380     +674     
============================================
+ Hits          46045    48317    +2272     
- Misses        47959    49925    +1966     
- Partials       6701     6927     +226     
Flag Coverage Δ
unit 29.25% <74.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action branch 3 times, most recently from 2cd2670 to 4b0b14d Compare January 9, 2025 13:50
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12701805770

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12701805770
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action branch 7 times, most recently from 770a0e3 to 8a19f3c Compare January 17, 2025 06:13
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action branch 2 times, most recently from d419754 to 9e77095 Compare January 17, 2025 06:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants