Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature remove registry SAML #6197

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

Osara-B
Copy link

@Osara-B Osara-B commented Dec 11, 2024

Proposed changes in this pull request

This is raised early in the development to validate incremental improvements done on the feature branch to test against the product-is integration tests using the pr builder action

When should this PR be merged

This is a draft PR. Do not merge this.

Copy link

sonarcloud bot commented Dec 11, 2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 68.73508% with 262 lines in your changes missing coverage. Please review.

Project coverage is 45.51%. Comparing base (fe23af6) to head (9833bf2).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...ore/dao/SAMLSSOServiceProviderRegistryDAOImpl.java 65.63% 101 Missing and 44 partials ⚠️
...entity/core/dao/SAMLSSOServiceProviderDAOImpl.java 77.30% 49 Missing and 15 partials ⚠️
.../identity/core/model/SAMLSSOServiceProviderDO.java 61.53% 3 Missing and 32 partials ⚠️
...n/identity/core/SAMLSSOServiceProviderManager.java 61.29% 10 Missing and 2 partials ⚠️
...y/core/persistence/IdentityPersistenceManager.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6197      +/-   ##
============================================
+ Coverage     45.34%   45.51%   +0.16%     
- Complexity    13842    14021     +179     
============================================
  Files          1614     1622       +8     
  Lines         99765   100921    +1156     
  Branches      16562    16758     +196     
============================================
+ Hits          45238    45931     +693     
- Misses        47881    48188     +307     
- Partials       6646     6802     +156     
Flag Coverage Δ
unit 27.96% <68.73%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants