Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce role properties object to store role related properties #6194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Dec 10, 2024

Proposed changes in this pull request

@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-branch branch 4 times, most recently from 9459b46 to 64c6385 Compare December 11, 2024 03:38
@ShanChathusanda93 ShanChathusanda93 marked this pull request as ready for review December 11, 2024 03:38
@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-branch branch 2 times, most recently from d352a76 to d440367 Compare December 11, 2024 04:03
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 45.07%. Comparing base (6224c1c) to head (55515c6).
Report is 217 commits behind head on master.

Files with missing lines Patch % Lines
...bon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java 22.22% 5 Missing and 2 partials ⚠️
.../identity/role/v2/mgt/core/model/RoleProperty.java 0.00% 7 Missing ⚠️
...2/carbon/identity/role/v2/mgt/core/model/Role.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6194      +/-   ##
============================================
- Coverage     45.42%   45.07%   -0.36%     
+ Complexity    14304    14063     -241     
============================================
  Files          1620     1621       +1     
  Lines        104694   103174    -1520     
  Branches      17540    17464      -76     
============================================
- Hits          47555    46501    -1054     
+ Misses        50192    49813     -379     
+ Partials       6947     6860      -87     
Flag Coverage Δ
unit 27.70% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-branch branch 6 times, most recently from a09b58d to d302fc8 Compare December 12, 2024 12:50
Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creating OAuth 2.0 clients inside B2B organizations for B2B API access
1 participant