Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the fragment app check when adding the app role association #6185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShanChathusanda93
Copy link
Contributor

Proposed changes in this pull request

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 2.12766% with 46 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (37745ca) to head (9804566).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ty/role/v2/mgt/core/RoleManagementServiceImpl.java 0.00% 33 Missing ⚠️
...on/mgt/listener/DefaultRoleManagementListener.java 0.00% 7 Missing ⚠️
...bon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java 14.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6185      +/-   ##
============================================
- Coverage     45.33%   45.29%   -0.04%     
+ Complexity    13832    13814      -18     
============================================
  Files          1614     1614              
  Lines         99700    99714      +14     
  Branches      16833    16837       +4     
============================================
- Hits          45196    45166      -30     
- Misses        47860    47908      +48     
+ Partials       6644     6640       -4     
Flag Coverage Δ
unit 27.67% <2.12%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the fragment-app-check-branch branch from 58c9507 to 2e2fe44 Compare December 9, 2024 06:51
@ShanChathusanda93 ShanChathusanda93 force-pushed the fragment-app-check-branch branch from 2e2fe44 to 9804566 Compare December 9, 2024 06:55
Copy link

sonarcloud bot commented Dec 9, 2024

@AnuradhaSK
Copy link
Contributor

Add unit test to cover changed code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for creating OAuth 2.0 clients inside B2B organizations for B2B API access
2 participants