Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ActionManagementAuditLogger #6180

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Dec 5, 2024

Proposed changes in this pull request

  1. Remove printAuditLog(Operation operation, String actionId,ActionDTO actionDTO) overloaded method as we can utilize printAuditLog(Operation operation, ActionDTO actionDTO) for all usecases.
  2. Improve tests for ActionManagementAuditLogger for both Add and Update operations

Related Issue

Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.03%. Comparing base (3b6ada1) to head (c39855e).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...n/management/util/ActionManagementAuditLogger.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6180   +/-   ##
=========================================
  Coverage     41.02%   41.03%           
- Complexity    15391    15398    +7     
=========================================
  Files          1796     1796           
  Lines        123037   122999   -38     
  Branches      21408    21403    -5     
=========================================
- Hits          50480    50475    -5     
+ Misses        65058    65034   -24     
+ Partials       7499     7490    -9     
Flag Coverage Δ
unit 27.67% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashanthamara
Copy link
Contributor Author

ashanthamara commented Dec 5, 2024

Not running the product-is PR builder as the changes in this PR are related to audit logs. Since we have not enabledV2audit logs in the integration tests, these changes won't be tested in the PR builder it self.

We have covered all the uses cases for the audit logs using the unit tests.
Hence merging the PR without running the pr builder.

@ashanthamara ashanthamara merged commit 9d9bf3c into wso2:master Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants