Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw signature exception from signing and signature validation utils #6179

Conversation

sadilchamishka
Copy link
Contributor

Proposed changes in this pull request

$subject

Copy link

sonarcloud bot commented Dec 5, 2024

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12173166665

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.02%. Comparing base (eee404d) to head (3b6ada1).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...g/wso2/carbon/identity/core/util/IdentityUtil.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6179      +/-   ##
============================================
- Coverage     41.03%   41.02%   -0.01%     
+ Complexity    15392    15391       -1     
============================================
  Files          1796     1796              
  Lines        123042   123037       -5     
  Branches      21408    21408              
============================================
- Hits          50485    50480       -5     
  Misses        65058    65058              
  Partials       7499     7499              
Flag Coverage Δ
unit 27.66% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadilchamishka sadilchamishka merged commit 18a8f0c into wso2:master Dec 5, 2024
4 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12173166665
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12173166665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants