Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode spName variable with OWASP Java Encoder #430

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Encode spName variable with OWASP Java Encoder #430

merged 1 commit into from
Nov 4, 2024

Conversation

KaveeshaPiumini
Copy link
Contributor

Purpose

  • This PR encodes the value of the spName variable by first using Encode.forUriComponent to ensure safe inclusion in URLs, followed by Encode.forJavaScriptBlock to protect against JavaScript injection, providing security for both URL and JavaScript contexts.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11627897415

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11627897415
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 1, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11627897415

@nilasini nilasini merged commit 42d090c into wso2-extensions:master Nov 4, 2024
3 checks passed
asha15 pushed a commit to asha15/identity-inbound-auth-saml-1 that referenced this pull request Nov 7, 2024
@wso2-jenkins-bot
[WSO2 Release] [Jenkins wso2-extensions#430] [Release 5.11.38] prepar…
63b66ab 
…e release v5.11.38
asha15 pushed a commit to asha15/identity-inbound-auth-saml-1 that referenced this pull request Nov 7, 2024
@wso2-jenkins-bot
[WSO2 Release] [Jenkins wso2-extensions#430] [Release 5.11.38] prepar…
8167e29 
…e for next development iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@nilasini nilasini nilasini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaveeshaPiumini @jenkins-is-staging @nilasini