Fix build #1156
Merged
Fix build #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
ddkohler
requested review from
untzag,
ksunden,
darienmorrow and
kameyer226
as code owners
kameyer226
approved these changes
Feb 22, 2024
|
Okay, it looks like there are still (several) build issues with the pdf. In the near term, I will remove pdf rendering, and make an issue. This will allow html docs to build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the near term, this is my final attempt to fix the pdf builds. I found I had some bad rendering still from improper rst writing (my bad from the last pr).
Since html hasn't had any problems building (just the pdf), I propose we turn off pdf renders if this issue persists. html is rendering just fine. If I don't learn anything with this build, I will turn off pdf builds.
It's hard to run our full sphinx workflow on windows, especially with the latex. I made some changes to the docs builds that make it a little more friendly for windows.