-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reworking wright-tools entry points #1152
Conversation
for the record, I would lean towards conversions and loading being separate commands, personally, though I don't necessarily have a problem with extending |
yeah, I totally agree it's not right to call everything under wt-tree. I really wish I use I will definitely rework the namespace to make it fit better with the tools. |
interact with crawl after table is made
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
fix typo
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
using multiple entry points
incorporate attrs filter in glob methods
try to use pathlib over os
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
directory is optional argument for most methods
for more information, see https://pre-commit.ci
number = int(number) | ||
sig_figs = len(str(number)) | ||
sig_figs -= 1 if "." in str(number) else 0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess we are presuming no Europeans who use commas instead of decimal points...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Europeans have to use .
when working with python anyways (unless they change default formatting). In any case, I don't see our notation as a meaningful hindrance. I am fine with the syntax as is until someone raises an issue.
|
||
|
||
if __name__ == "__main__": | ||
cli() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a CLI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a feature request (issue #653). A quick entry point to check how units convert (according to wright tools)
Changes
wt-tree
removedwt-convert
for cli access to our unit conversions (resolves wt-convert entry point #653)wt5
with commands tree, load, glob, explorewt5
entry point for such utilitiesChecklist