Sort the assets by creation time in the version endpoint, just like /assets #597
Conversation
…assets We made the asset list in the GET version endpoint more useful recently by including the asset-id. But that list is not being sorted by creation time, unlike the list provided by /assets, so the assets are somewhat randomly ordered. So, add the change to sort the asset list of the GET version endpoint by creation time. This ensures that the default asset is always first, etc.
|
We don't know if this will break anyone, though, right? I'm not opposed to the change, but can we add an explanation of the |
Updating doc based on good comment from Gary.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #597 +/- ##
========================================
Coverage 81.18% 81.18%
========================================
Files 129 129
Lines 5842 5842
========================================
Hits 4743 4743
Misses 1099 1099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OK, added a comment for the docs for both the "Get Version" and "Get Version Assets" endpoints. Thanks for the suggestion! |
Sort the assets by creation time in the version endpoint, just like the /assets endpoint
We made the asset list in the GET version endpoint more useful recently by including the asset-id. But that list is not being sorted by creation time, unlike the list provided by /assets, so the assets are somewhat randomly ordered.
So, add the change to sort the asset list of the GET version endpoint by creation time. This ensures that the default asset is always first, etc. (same as the ordering in _build_filtered_query)