Api gateway relax quota #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomon-negusse
commented
Jun 3, 2024
| @@ -180,13 +180,6 @@ resource "aws_api_gateway_usage_plan" "internal" { | |||
| burst_limit = var.api_gateway_usage_plans.internal_apps.burst_limit | |||
| rate_limit = var.api_gateway_usage_plans.internal_apps.rate_limit | |||
| } | |||
|
|
|||
| # terraform doesn't expose API Gateway's method level throttling so will do that | |||
There was a problem hiding this comment.
Turns out it's not possible to add daily quotas at method level so won't be setting anything manually that necessitated this.. and there's terraform way to do that now in case we need that
dmannarino
approved these changes
Jun 3, 2024
danscales
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Quota limits can potentially be exceeded with normal usage now that both query and download endpoints contribute to it
What is the new behavior?
Increased daily quota
Does this introduce a breaking change?
Other information