Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate src_uris concurrently #456

Closed
wants to merge 31 commits into from
Closed

Conversation

dmannarino
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@@ -528,7 +525,11 @@ def _verify_source_file_access(sources: List[str]) -> None:

for source in sources:
url_parts = urlparse(source, allow_fragments=False)
list_func = source_uri_lister_constructor[url_parts.scheme.lower()]
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in our huddle, I think it'd solve the problem better to make the invalid sources check a background task that just sets the version to failed rather than doing it upfront. But also might require better error messaging in the version metadata.

Alternative workaround: have datapump just send a directory rather than all the source URIs.

@dmannarino dmannarino changed the title WIP: Check src_uris in parallel Validate src_uris concurrently Jan 20, 2024
@dmannarino dmannarino closed this Jan 22, 2024
@dmannarino dmannarino deleted the asyncify_boto3_usage branch January 22, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants