-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate src_uris concurrently #456
Conversation
… (GCS complete rewrite)
…tests; fixes to latter
…e (with new lib) for async; use moto for secrets too; change default moto port
@@ -528,7 +525,11 @@ def _verify_source_file_access(sources: List[str]) -> None: | |||
|
|||
for source in sources: | |||
url_parts = urlparse(source, allow_fragments=False) | |||
list_func = source_uri_lister_constructor[url_parts.scheme.lower()] | |||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in our huddle, I think it'd solve the problem better to make the invalid sources check a background task that just sets the version to failed rather than doing it upfront. But also might require better error messaging in the version metadata.
Alternative workaround: have datapump just send a directory rather than all the source URIs.
…ess tightly with get_matching_gs_files
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information