Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pixetl fixed for rasterizing vectors #452

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

dmannarino
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

As before the ill-fated pixetl 1.7.5, rasterizing vector datasets can crash the DB

Issue Number: N/A

What is the new behavior?

  • Rasterizing vector datasets is done more carefully, limiting parallelization when accessing the DB

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f285d5f) 80.32% compared to head (1ca5114) 80.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #452   +/-   ##
========================================
  Coverage    80.32%   80.32%           
========================================
  Files          124      124           
  Lines         5515     5515           
========================================
  Hits          4430     4430           
  Misses        1085     1085           
Flag Coverage Δ
unittests 80.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmannarino dmannarino marked this pull request as ready for review January 25, 2024 17:25
@dmannarino dmannarino merged commit 396f065 into develop Jan 26, 2024
2 checks passed
@dmannarino dmannarino deleted the robustify_pixetl_mark_2 branch January 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants