Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTC-1866: fix: Remove extra quotes from error message #350

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

gtempus
Copy link
Contributor

@gtempus gtempus commented Oct 20, 2022

I didn't notice the subtle difference between the variables: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-mapping-template-reference.html

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The error message for an integration timeout has a double set of quotation marks. It's not valid JSON:
Request: https://data-api.globalforestwatch.org/assets
Response:

{
    "status": "failed",
    "message": " "Endpoint request timed out" : Use the pagination query parameters when available. See the API documentation."
}

Issue Number: GTC-1866

What is the new behavior?

The new property should not have quotation marks.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@gtempus gtempus merged commit 1461f10 into develop Oct 20, 2022
@gtempus gtempus deleted the fix/GTC-1866-double-quotes branch October 20, 2022 18:05
@jterry64 jterry64 restored the fix/GTC-1866-double-quotes branch December 18, 2024 23:54
@jterry64 jterry64 deleted the fix/GTC-1866-double-quotes branch December 18, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants