various optimizations & fixes

- memoize useRouteTitle() - fix type of default 404 template name - fix Geo & Draw state issues
wq · Oct 4, 2023 · 441caab · 441caab
1 parent f3e823d
commit 441caab
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/packages/map-gl-web/src/overlays/Draw.js b/packages/map-gl-web/src/overlays/Draw.js
@@ -14,15 +14,14 @@ export default function Draw({ type, required, data, setData }) {
         controls.trash = true;
     }
     const draw = useControl(
-        (props) => {
+        () => {
             const { classes } = MapboxDraw.constants;
             for (const [key, value] of Object.entries(classes)) {
                 if (value.startsWith("mapboxgl-")) {
                     classes[key] = value.replace("mapboxgl-", "maplibregl-");
                 }
             }
             return new MapboxDraw({
-                ...props,
                 displayControlsDefault: false,
                 controls,
             });

diff --git a/packages/map/src/inputs/Geo.js b/packages/map/src/inputs/Geo.js
@@ -12,7 +12,7 @@ import PropTypes from "prop-types";
 export default function Geo({
     name,
     type,
-    mapId = null,
+    mapId = undefined,
     required,
     label,
     hint,

diff --git a/packages/react/src/hooks.js b/packages/react/src/hooks.js
@@ -98,17 +98,20 @@ export function useRouteTitle(routeName) {
         { getRouteTitle } = app.router,
         config = useConfig();
 
-    function routeTitle(routeName) {
-        const [name, mode, variant] = app.splitRoute(routeName);
-        const page_config = config.pages[name] || {
-            name,
-        };
-        return getRouteTitle({
-            page_config,
-            mode,
-            variant,
-        });
-    }
+    const routeTitle = useCallback(
+        (routeName) => {
+            const [name, mode, variant] = app.splitRoute(routeName);
+            const page_config = config.pages[name] || {
+                name,
+            };
+            return getRouteTitle({
+                page_config,
+                mode,
+                variant,
+            });
+        },
+        [app, routeName, config]
+    );
 
     if (routeName) {
         return routeTitle(routeName);

diff --git a/packages/router/src/router.js b/packages/router/src/router.js
@@ -30,7 +30,7 @@ const defaultQuerySerializer = {
 var router = {
     config: {
         store: "main",
-        tmpl404: 404,
+        tmpl404: "404",
         debug: false,
         getTemplateName: (name) => name,
         querySerializer: defaultQuerySerializer,