New: adds a document denied redirect page setting #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadNateqi
requested changes
Aug 25, 2023
|
Whatever access type I select with a custom link, it redirects me to the login page.
When I have access type of 'Full' or 'Logged in' without a custom link, I can download the PDF. But if i change the permission to 'Guest' without a custom link, i get the no permission page. |
YordanSoares
requested changes
Aug 25, 2023
|
@dwalkerpriv external links are not allowed, could you try with a store frontend link? |
dwalkerpriv
approved these changes
Aug 28, 2023
Actually I added today after your comment :) |
YordanSoares
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
@alexmigf now it works well!
However, I think we should move the "Custom external URLs not allowed." text to the custom URL input, like this:
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #586
This PR adds a new selector for a document access denied redirect page in the frontend:
Instead of dying immediately. Other options are: