-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: adds UBL as additional output format for documents #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you have applied WPCS on the UBL directory, it would be great if you could rename the function to follow the sneak case, or we can create another issue as the changes may be significant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Alex!
Thank you for your efforts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine on my end. Settings exported and imported without issues as well
I was thinking that maybe we should rename the plugin following this implementation. Joe have mentioned this in past meetings, maybe something like this:
But I don't like seeing two What do you guys think? @dwalkerpriv @YordanSoares @MohamadNateqi @Terminator-Barbapapa |
@alexmigf I agree with you that having two "&" symbols can look cluttered. Also, I wanted to say that I like the idea of renaming, as it improves clarity and reflects this new feature that can also be good in terms of SEO, but I'm also sort of worried about the impact of this change as this plugin has been around for years with this name. |
Shouldn't have a huge impact, we have also renamed it recently to change the "for WooCommerce" to the end of the name. I think we should have some space outside the
The second seems better to me. |
Yeah, having some space around |
This makes me recall that in Spain people often joke about how good is our plugin, but how difficult is to remember its name. To be honest, if we're willing to rename the plugin, I would prefer to run a brainstorming and look for a branding short name, not a name that states-all-the-document-types-our-plugin-offers. Then we can mention what our plugin does as a subtitle or within the plugin descriptions in both on WordPress.org and our store. For instance:
Here, some naming ideas to start with:
|
By rename I didn't mean change all name, just a way to include the UBL there somehow. Full rename, or brand rename should be discussed privately in Slack I think, and maybe including the marketing department from UpdraftPlus. |
In regards to incorporating UBL in the name, "PDF / UBL Invoices & Packing Slips for WooCommerce" is pretty simple and straight forward enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are there. Awesome work! 🎊
closes #481
This PR adds support for UBL format in companion with the existing PDF output. This will replace our UBL addon, and future developments on UBL must be done on this plugin instead.
Specs
sabre\xml
dependency and updated to version2.2.5
(supports PHP 7.1+, min version required for this plugin)3.6.0
versionxml
output on preview when UBL tab is selected in the document settingsScreenshots
Document settings for UBL format:
UBL output preview:
Taxes classification:
New dynamic action button (can be generated for other UBL documents):
Bulk actions support:
New independent meta box for UBL in the order page:
UBL document settings export/import support: