Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save invoice display date option #489

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Conversation

aparnascodex
Copy link
Contributor

This PR is part of Add 'Display invoice date' option issue.

Copy link
Member

@alexmigf alexmigf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could display the date label in the Document data table:

Screenshot from 2023-03-28 14-30-48

includes/documents/class-wcpdf-invoice.php Outdated Show resolved Hide resolved
@aparnascodex aparnascodex requested a review from alexmigf April 3, 2023 03:00
@Terminator-Barbapapa
Copy link
Contributor

The value isn't updated when regenerating the document:

Schermafbeelding 2023-04-03 om 13 12 02

@aparnascodex
Copy link
Contributor Author

@Terminator-Barbapapa I have added code to update the value on document regeneration.

@alexmigf alexmigf self-requested a review April 3, 2023 15:10
@alexmigf alexmigf merged commit 13f962e into main Apr 4, 2023
@alexmigf alexmigf deleted the save-invoice-display-date-option branch April 4, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants