Added variable to control wpilib version easier. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzblue
suggested changes
Oct 23, 2024
ThadHouse
reviewed
Dec 3, 2024
ThadHouse
approved these changes
Dec 3, 2024
ThadHouse
reviewed
Dec 3, 2024
| @@ -8,7 +8,7 @@ nativeUtils.withCrossLinuxArm64() | |||
| nativeUtils { | |||
| wpi { | |||
| configureDependencies { | |||
| wpiVersion = "2025.+" | |||
| wpiVersion = wpilibVersion | |||
| opencvYear = "frc2024" | |||
There was a problem hiding this comment.
Can you also add the same things for opencvYear and opencvVersion? That way the versions that are shared are in a common place.
There was a problem hiding this comment.
Yes, but that was out of scope of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version variable is purely there to make it easier to control the WPILib version in a centralized manner.