Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendordep Templating. #41

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

thenetworkgrinch
Copy link
Contributor

Outputs filled out vendordep file to $buildDir/repos/ with filled in variables from the gradle config.

Copy link
Member

@rzblue rzblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to generate this as an artifact that gets published

publish.gradle Outdated Show resolved Hide resolved
@thenetworkgrinch
Copy link
Contributor Author

Like this? I am not sure how to add it to MavenPublication. I tried doing

vendordep(MavenPublication) {
                artifact vendordepJson

                artifactId = "${baseArtifactId}-vendordep"
                groupId artifactGroupId
                version pubVersion
            }

but it didnt recognize the artifact type as valid even though it outputs a file.

@thenetworkgrinch
Copy link
Contributor Author

thenetworkgrinch commented Oct 23, 2024

I just made a zip task which wraps up the generated vendordep and is able to publish it to maven.

I still dont think this is necessary or a good idea? Why would you want to publish your vendordep to maven when its supposed to be hosted and accessible?

The current version where it outputs the vendordep to $buildDir seems fine and really would be better off if it outputted to $buildDir/repos. That way vendors can copy $buildDir/repos over to their webhost and have it be done.

publish.gradle Outdated Show resolved Hide resolved
publish.gradle Outdated Show resolved Hide resolved
publish.gradle Outdated Show resolved Hide resolved
@ThadHouse
Copy link
Member

On lines 172 and 177 of build.gradle, add addTaskToCopyAllOutputs(vendordepJsonZip) and build.dependsOn vendordepJsonZip

@ThadHouse ThadHouse merged commit 93767cf into wpilibsuite:2025 Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants