Validate gradle wrapper inline #7582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to v4 of the gradle wrapper validation action
rzblue
previously requested changes
Dec 23, 2024
Co-authored-by: Ryan Blue <[email protected]>
auscompgeek
reviewed
Dec 24, 2024
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: gradle/actions/wrapper-validation@v4 |
There was a problem hiding this comment.
This workflow doesn't run on PRs, so I don't think it's super necessary here?
There was a problem hiding this comment.
Agree it's not super necessary, but my thought was that if the action fixes a bug or adds another check, this would catch something that made it to main.
PeterJohnson
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to v4 of the gradle wrapper validation action