Fixed sendable logging in epilogue #7518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
/format |
|
/cancel |
|
That's not a command we have... |
|
Unfortunately, this approach won't work. Mechanism2d and Field2d classes keep internal references to the last NTSendableBuilder they're used with, so epilogue logging calls would prevent dashboards from updating. @Logged
Field2d field = ...;
public Robot() {
SmartDashboard.putData("Field", field);
Epilogue.bind(this); // Silently breaks the SD put
}I consider this more a bug in the NTSendable-related API and how it's used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed NT-only Sendables(Field2d, Mechanism2d, etc) not being logged with epilogue's @Logged annotation.