[wpimath] Improve SimpleMotorFeedforward argument names and deprecation message #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamCarlberg
reviewed
Dec 5, 2024
wpimath/src/main/java/edu/wpi/first/math/controller/SimpleMotorFeedforward.java
Outdated
Show resolved
Hide resolved
calcmogul
force-pushed
the
wpimath-improve-simple-motor-feedforward-arg-names-and-deprecation-msg
branch
from
cca6d7e to
b36bccc
Compare
calcmogul
force-pushed
the
wpimath-improve-simple-motor-feedforward-arg-names-and-deprecation-msg
branch
from
5d907b3 to
672fa6d
Compare
…on message Also roll back SimpleMotorFeedforward unit API until 2027.
calcmogul
force-pushed
the
wpimath-improve-simple-motor-feedforward-arg-names-and-deprecation-msg
branch
from
672fa6d to
caebbed
Compare
PeterJohnson
approved these changes
Dec 7, 2024
calcmogul
deleted the
wpimath-improve-simple-motor-feedforward-arg-names-and-deprecation-msg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also roll back SimpleMotorFeedforward unit API until 2027.