Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add Buildifier to /format comment command #7480

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

spacey-sooty
Copy link
Contributor

No description provided.

@spacey-sooty spacey-sooty requested a review from a team as a code owner December 3, 2024 06:22
@Gold856
Copy link
Contributor

Gold856 commented Dec 3, 2024

If you want, you can try turning the whole Buildifier setup into a composite action like in #7474. There have already been multiple instances of people forgetting to update one side when they update the other, so it's better to unify the common steps into a composite action to make it harder to forget a step somewhere.

@spacey-sooty
Copy link
Contributor Author

I'll make a seperate PR to do that for all the formatting stuff

@PeterJohnson PeterJohnson changed the title [ci] Make Buildifier run in comment command [ci] Add Buildifier to /format comment command Dec 18, 2024
@PeterJohnson PeterJohnson merged commit 66cce18 into wpilibsuite:main Dec 18, 2024
42 checks passed
@spacey-sooty spacey-sooty deleted the buildifer-in-format branch December 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants