-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd] Add Scheduled command decorator #7083
Closed
narmstro2020
wants to merge
44
commits into
wpilibsuite:main
from
narmstro2020:ScheduledCommand-decorator
Closed
Changes from 36 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
6b45ec5
first draft
narmstro2020 0c5fa51
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 1fb92f0
Formatting fixes
github-actions[bot] 2952b47
fix Java argument requirements
narmstro2020 8927cc2
Merge branch 'ScheduledCommand-decorator' of https://github.com/narms…
narmstro2020 0ed013f
Formatting fixes
github-actions[bot] 883c761
missing period
narmstro2020 dc8e576
Merge branch 'ScheduledCommand-decorator' of https://github.com/narms…
narmstro2020 c863eb5
removed C++ for now
narmstro2020 256dc21
fully remove c++ for now.
narmstro2020 9a684d6
Formatting fixes
github-actions[bot] cfd03b9
param rename
narmstro2020 3540205
Formatting fixes
github-actions[bot] 8b170f4
fixed loop copy of array
narmstro2020 3e58989
formatting fixes
narmstro2020 6e7f396
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 8f390e5
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 21d7f33
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 bc3595b
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 8c15f99
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 fcfcb55
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 1191215
attempt
narmstro2020 feaedf6
Merge branch 'wpilibsuite:main' into ScheduledCommand-decorator
narmstro2020 1b64ab2
pointer updates
narmstro2020 5172e87
fix thanks space-sooty
narmstro2020 4793d6c
Formatting fixes
github-actions[bot] e4d268d
varargs added?
narmstro2020 fd9ae09
Merge branch 'ScheduledCommand-decorator' of https://github.com/narms…
narmstro2020 8420248
revert
narmstro2020 7f05e7d
varargs attempt 2
narmstro2020 f9abc95
another attempt using std::vector
narmstro2020 13313f3
revert again
narmstro2020 49c52c0
Formatting fixes
github-actions[bot] 71a038c
separate overload
narmstro2020 69b8809
Merge branch 'ScheduledCommand-decorator' of https://github.com/narms…
narmstro2020 d1b111d
possible fix
narmstro2020 47abdc8
Formatting fixes
github-actions[bot] 44f542e
Update wpilibNewCommands/src/main/native/cpp/frc2/command/CommandPtr.cpp
narmstro2020 e208fa9
revert
narmstro2020 b667e18
requested changes
narmstro2020 d2ff9c3
Merge branch 'ScheduledCommand-decorator' of https://github.com/narms…
narmstro2020 5124914
formatting fixes
narmstro2020 e2ff78a
formatting fixes
narmstro2020 9c6c77f
updates
narmstro2020 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an overload for
Fork(CommandPtr&&... other)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting this error right as I add the overload
declaration is incompatible with "frc2::CommandPtr frc2::CommandPtr::Fork(frc2::CommandPtr &&other) &&" (declared at line 60)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I guess this makes sense, an overload with a std::span and maybe std::vector works as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That definitely will not work. It would need to be a seperate overload if varargs can work here but I'm not sure they can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I've added a separate overload with no major code mods (just a copy).
I'm getting this error after other
expected a ')'C/C++(18)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is weird because the parentheses match up. Is there something i'm missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this, I'll use std vector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I'm floudering on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I just leave out the overload?