[build] Add unused public or protected field to spotbugs exclude

[spacey-sooty]

No description provided.

[sciencewhiz]

What problem does this solve? It generally doesn't seem like a good thing to exclude.

[rzblue]

If a field is public it's likely intended to be used outside of the current class, which spotbugs won't see.

[calcmogul]

iirc, one of our tools besides spotbugs reports unused private fields.

[ThadHouse]

I think this specific case is getting confused since it’s used by the annotation processor, which spotless doesn’t see.

[spacey-sooty]

iirc, one of our tools besides spotbugs reports unused private fields.

Unused private fields makes sense to report, public and protected fields can be used outside of the class such as in #6893 which is failing because of this warning

[sciencewhiz]

Unused private fields makes sense to report, public and protected fields can be used outside of the class such as in #6893 which is failing because of this warning

It still seems pretty rare that you'd have a public variable that is never used within that class. Why not just suppress those two occurrences in that PR? Beachbot330@b826dee

[spacey-sooty]

It still seems like a silly warning to me; I'll supress those for now though

[spacey-sooty]

Supressing warnings actually gives us a choice to make. How do we want to add the annotation?
Adding it as a dependency is a pain (we need to hold the version to spotbugs to the manually)
If we don't add it as a dependency we have to support the annotation ourselves.