[upstream_utils] Add Catch2

[spacey-sooty]

Resolves #6946

[spacey-sooty]

How do we wanna approach the Gradle build for this?
Does Gradle have a configure_file equivalent?

[spacey-sooty]

Wait how is gradle passing 💀

[spacey-sooty]

I don't think what I've done so far address the #cmakedefines

[PeterJohnson]

Well, I don't think we need to globally support the cmakedefine's, only what we think we'll actually want to customize in the gradle config. What you have is likely good enough.

[spacey-sooty]

Well, I don't think we need to globally support the cmakedefine's, only what we think we'll actually want to customize in the gradle config. What you have is likely good enough.

In that case this is ready for review 🙂

[PeterJohnson]

I think it would be good to add in this PR a simple catch2 test in wpiutil to check to make sure it actually works and hooks into the build the way we want.

[spacey-sooty]

The tests wont run on Gradle cause we dont have a Catch2 test runner (I don't think that should be blocking for this pr though)

[Gold856]

Try copying googletest.gradle and swapping out the googletest references with catch2. Then apply the new catch2 file the same way the googletest file is applied. I don't think we actually use Gradle's googletest-specific integrations, since I think we just run the test executable and check for exit code 0. If that's the case, we can pretend like our Catch2 tests are "GoogleTest" tests, and Gradle shouldn't have a problem with running them.

[spacey-sooty]

We use GoogleTestTestSuiteBinarySpec which is part of Gradle's integration?

[spacey-sooty]

Ohh I think I see the issue its like the dumb protobuf bs

[Gold856]

Looks like you're going to have to patch the user config header to not have #cmakedefine. How you handle that is up to you (use an ifndef and a define for Gradle, removing them entirely, etc.)

[spacey-sooty]

I guess it wouldn't be too hard to just replace every cmakedefine with a define...

[spacey-sooty]

Gradle hates me

[Gold856]

Probably want to update this to use the latest commit of Catch2 as well.

[Gold856]

I think the solution to the config header is to just clone the repo, configure the build with CMake, and copy the generated header into our source tree. Bonus points if you can set up a generation script for it.

[spacey-sooty]

I think the solution to the config header is to just clone the repo, configure the build with CMake, and copy the generated header into our source tree. Bonus points if you can set up a generation script for it.

I took a look at the generated file, we actually only need to replace two options (the one with values). The rest can be commented out and it'll use the default. I think if we can do that properly it'll be fine.