Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpiutil] Remove Protobuf.getNested() #6812

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[wpiutil] Remove Protobuf.getNested() #6812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Ellipse2dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ public Descriptor getDescriptor() {
return ProtobufEllipse2d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Pose2d.proto};
}

@Override
public ProtobufEllipse2d createMessage() {
return ProtobufEllipse2d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Pose2dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufPose2d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Translation2d.proto, Rotation2d.proto};
}

@Override
public ProtobufPose2d createMessage() {
return ProtobufPose2d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Pose3dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufPose3d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Translation3d.proto, Rotation3d.proto};
}

@Override
public ProtobufPose3d createMessage() {
return ProtobufPose3d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Rectangle2dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ public Descriptor getDescriptor() {
return ProtobufRectangle2d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Pose2d.proto};
}

@Override
public ProtobufRectangle2d createMessage() {
return ProtobufRectangle2d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Rotation3dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ public Descriptor getDescriptor() {
return ProtobufRotation3d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Quaternion.proto};
}

@Override
public ProtobufRotation3d createMessage() {
return ProtobufRotation3d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Transform2dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufTransform2d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Translation2d.proto, Rotation2d.proto};
}

@Override
public ProtobufTransform2d createMessage() {
return ProtobufTransform2d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/geometry/proto/Transform3dProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufTransform3d.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Translation3d.proto, Rotation3d.proto};
}

@Override
public ProtobufTransform3d createMessage() {
return ProtobufTransform3d.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/kinematics/proto/MecanumDriveKinematicsProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufMecanumDriveKinematics.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Translation2d.proto};
}

@Override
public ProtobufMecanumDriveKinematics createMessage() {
return ProtobufMecanumDriveKinematics.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/kinematics/proto/SwerveModulePositionProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufSwerveModulePosition.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Rotation2d.proto};
}

@Override
public ProtobufSwerveModulePosition createMessage() {
return ProtobufSwerveModulePosition.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/kinematics/proto/SwerveModuleStateProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufSwerveModuleState.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Rotation2d.proto};
}

@Override
public ProtobufSwerveModuleState createMessage() {
return ProtobufSwerveModuleState.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/trajectory/proto/TrajectoryProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ public Descriptor getDescriptor() {
return ProtobufTrajectory.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Trajectory.State.proto};
}

@Override
public ProtobufTrajectory createMessage() {
return ProtobufTrajectory.newInstance();
Expand Down
5 changes: 0 additions & 5 deletions wpimath/src/main/java/edu/wpi/first/math/trajectory/proto/TrajectoryStateProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ public Descriptor getDescriptor() {
return ProtobufTrajectoryState.getDescriptor();
}

@Override
public Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {Pose2d.proto};
}

@Override
public ProtobufTrajectoryState createMessage() {
return ProtobufTrajectoryState.newInstance();
Expand Down
9 changes: 0 additions & 9 deletions wpiutil/src/main/java/edu/wpi/first/util/protobuf/Protobuf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,6 @@ default String getTypeString() {
*/
Descriptor getDescriptor();

/**
* Gets the list of protobuf types referenced by this protobuf.
*
* @return list of protobuf types
*/
default Protobuf<?, ?>[] getNested() {
return new Protobuf<?, ?>[] {};
}

/**
* Creates protobuf message.
*
Expand Down
Loading