[wpimath] Add Reset methods to PoseEstimator #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacey-sooty
force-pushed
the
estimatorreset
branch
2 times, most recently
from
0d760f5 to
a5478bb
Compare
Requires wpilibsuite#6702 Resolves wpilibsuite#5001
spacey-sooty
force-pushed
the
estimatorreset
branch
from
a5478bb to
15c818f
Compare
calcmogul
approved these changes
Jul 9, 2024
virtuald
reviewed
Aug 21, 2024
| template <typename WheelSpeeds, typename WheelPositions> | ||
| void PoseEstimator<WheelSpeeds, WheelPositions>::ResetRotation( | ||
| const Rotation2d& rotation) { | ||
| m_odometry.ResetTranslation(rotation); |
There was a problem hiding this comment.
This should be ResetRotation? It would be good if some test was added that instantiated these templates to catch compile errors like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6702
Resolves #5001