Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Transform protocol-less src to https instead of http #127

Closed
wants to merge 1 commit into from

Conversation

danielbachhuber
Copy link
Contributor

If we're provided a protocol-less URL, we can safely assume it supports https

See #107

If we're provided a protocol-less URL, we can safely assume it supports https
@danielbachhuber
Copy link
Contributor Author

@goldenapples #reviewmerge

@goldenapples
Copy link
Contributor

I don't think we want to do this for all tags, do we? This might work for script tags, but an https iframe on an http page will cause problems with postmessage communication.

I think it would make more sense to store the url field as protocol-less if that's how it's provided to us.

@danielbachhuber
Copy link
Contributor Author

This might work for script tags, but an https iframe on an http page will cause problems with postmessage communication.

Touche. Let's 🏈

@danielbachhuber danielbachhuber deleted the 107-protocolless branch September 30, 2015 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants