Closes #70 Add scenario for pages without LCP/ATF #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeawhanlee
requested changes
May 10, 2024
jeawhanlee
requested changes
May 14, 2024
jeawhanlee
requested changes
May 15, 2024
jeawhanlee
previously approved these changes
May 15, 2024
jeawhanlee
requested changes
May 16, 2024
jeawhanlee
changed the base branch from
trunk
to
enhancement/71-use-result-file-for-lcp-tests
jeawhanlee
reviewed
May 16, 2024
jeawhanlee
requested changes
May 16, 2024
|
|
||
| Scenario: Beacon captures expected images in desktop | ||
| When I log out | ||
| And I visit the urls for 'desktop' | ||
| Then lcp and atf should be as expected for 'desktop' | ||
|
|
||
| Scenario: Beacon captures expected images in mobile | ||
| Given I install plugin 'https://github.com/wp-media/wp-rocket-e2e-test-helper/blob/main/helper-plugin/force-wp-mobile.zip' | ||
| And plugin 'force-wp-mobile' is activated | ||
| When I log out | ||
| And I visit the urls for 'mobile' | ||
| Then lcp and atf should be as expected for 'mobile' |
There was a problem hiding this comment.
Suggested change
| Then lcp and atf should be as expected for 'mobile' | |
| And plugin 'force-wp-mobile' is deactivated |
| When I log out | ||
| And I visit the urls for 'mobile' | ||
| Then lcp and atf should be as expected for 'mobile' | ||
| And plugin 'force-wp-mobile' is deactivated |
There was a problem hiding this comment.
Suggested change
| And plugin 'force-wp-mobile' is deactivated | |
| Then lcp and atf should be as expected for 'mobile' |
jeawhanlee
approved these changes
May 16, 2024
jeawhanlee
merged commit 18509cf
into
enhancement/71-use-result-file-for-lcp-tests
1 check passed
jeawhanlee
added a commit
that referenced
this pull request
May 22, 2024
* Closes #71: Use results file instead of API for lcps * Comply feedback * Removed unused hook * Fix bugs + Update tests results * Updates expected results Add is_mobile is sql query Accept array for lcps * Comply linter * Comply feedback * Updated fixture * Updated hardcoded atf urls to relative (#81) * Closes #70 Add scenario for pages without LCP/ATF (#76) * Add scenario for no lcp/atf, add plugin deactivation function #70 :closes: * fixed lint * minor fix * Add step to activate and deactivate mobile plugin * update gitignore file * PR modifications * Add new command function, pr modifications --#70 * minor modifications * Add beacon check for lcp pages * deactivate plugin, modify json * Add missing step * change steps * Closes #82: LCP test not failing with no result in db (#84) * Make tests fail when no result in db * Fail tests early * Make log red --------- Co-authored-by: Michael Lee <[email protected]> Co-authored-by: Michael Lee <[email protected]> Co-authored-by: Opeyemi Ibrahim <[email protected]>
jeawhanlee
added a commit
that referenced
this pull request
May 29, 2024
…86) * Closes #71: Use results file instead of API for lcps * Comply feedback * Fix bugs + Update tests results * Updates expected results Add is_mobile is sql query Accept array for lcps * Comply linter * Comply feedback * Updated fixture * Updated hardcoded atf urls to relative (#81) * Closes #70 Add scenario for pages without LCP/ATF (#76) * Add scenario for no lcp/atf, add plugin deactivation function #70 :closes: * fixed lint * minor fix * Add step to activate and deactivate mobile plugin * update gitignore file * PR modifications * Add new command function, pr modifications --#70 * minor modifications * Add beacon check for lcp pages * deactivate plugin, modify json * Add missing step * change steps * Closes #82: LCP test not failing with no result in db (#84) * Make tests fail when no result in db * Fail tests early * Make log red * :chore: Add scenario and step for relative lcp image template -- #85 * PR modifications --------- Co-authored-by: Gael Robin <[email protected]> Co-authored-by: Michael Lee <[email protected]> Co-authored-by: Michael Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #70
Documentation
Technical documentation
This PR add checks for pages with no LCP/ATF and check the DB to assert the result are as expected.
Type of change
New dependencies
N/A
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Checklists
Feature validation
Code style