Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #163 Step to delete WPR failing in smoke test #164

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Fix #163 Step to delete WPR failing in smoke test #164

merged 3 commits into from
Oct 30, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #163
Modify the delete plugin feature.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Use the deleteWPRViaUI option when deleting the plugin

Technical description

Documentation

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal requested a review from a team October 24, 2024 10:21
@Khadreal Khadreal self-assigned this Oct 24, 2024
@Khadreal Khadreal changed the title Fix #163 Modify delete plugin method, remove auth from method -- :close #163 Fix #163 Step to delete WPR failing in smoke test Oct 24, 2024
Miraeld
Miraeld previously approved these changes Oct 24, 2024
View reviewed changes
jeawhanlee
jeawhanlee requested changes Oct 25, 2024
View reviewed changes
utils/page-utils.ts Show resolved Hide resolved
@Khadreal Khadreal requested a review from jeawhanlee October 28, 2024 09:24
hanna-meda
hanna-meda approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Khadreal, for this PR.
Running smoke on e2e on PR #164 with 3.17.2-alpha1 all tests pass.
cucumber-report-PR164.html.zip

@hanna-meda hanna-meda merged commit 2f39a0c into develop Oct 30, 2024
2 checks passed
@hanna-meda hanna-meda deleted the fix/163-steps-to-delete-wpr branch October 30, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanna-meda hanna-meda hanna-meda approved these changes

@jeawhanlee jeawhanlee jeawhanlee approved these changes

@Miraeld Miraeld Miraeld left review comments

Assignees

@Khadreal Khadreal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Step to delete WPR failing in smoke test
4 participants
@Khadreal @Miraeld @jeawhanlee @hanna-meda