added function for changing permalink. created performance-hints file… #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and added steps for 2 scenarios
jeawhanlee
reviewed
Aug 23, 2024
|
@hanna-meda Overall Good Job 🙌 |
jeawhanlee
requested changes
Sep 2, 2024
jeawhanlee
requested changes
Sep 10, 2024
Mai-Saad
reviewed
Sep 13, 2024
…ta if present or removed
|
test results ✔️ |
Miraeld
approved these changes
Sep 23, 2024
jeawhanlee
approved these changes
Sep 23, 2024
Mai-Saad
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function for changing permalink. created performance-hints files and added steps for 2 scenarios
Description
Partial work on #126
This commit covers:
Scenario: Should clear performance hints data when click clear PH in admin bar
Given WPR installed and activated
And performance hints data added to DB
When clear performance hints is clicked in admin bar
Then data is removed from the performance hints tables
Scenario: Should clear performance hints when change permalinks
Given WPR installed and activated
And performance hints data added to DB
When permalinks is changed
Then data is removed from the performance hints tables
Note: Scenarios still need more testing and refinement.