Closes #124: Adapt the LCP test for latest refactor of beacon script #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the reference to the container for the LCP beacon script as it got refactored and renamed.
remyperona
approved these changes
Jul 18, 2024
|
Everything looks fine with the new beacon script. Merging it |
MathieuLamiot
added a commit
that referenced
this pull request
Jul 31, 2024
…-change-lcp-beacon-name"" This reverts commit ca35844.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the reference to the container for the LCP beacon script as it got refactored and renamed.
Fixes #124
Documentation
Technical documentation
Issue related to wp-media/wp-rocket#6764
Renaming the selector to check if the beacon as finished to run or not.
Type of change