Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:closes: smoke test plugin error #122

Merged
merged 2 commits into from
Jul 9, 2024
Merged

:closes: smoke test plugin error #122

merged 2 commits into from
Jul 9, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Jul 2, 2024

Description

Fixed plugin uninstalled error message during smoke test run
Fixes #123

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Khadreal Khadreal marked this pull request as ready for review July 2, 2024 14:48
@Khadreal Khadreal changed the title 🐛 Fixed uninstall error during cleanup for plugin that is not ins… :closes: smoke test plugin error Jul 2, 2024
@Khadreal Khadreal requested a review from a team July 2, 2024 14:49
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Jul 8, 2024

I tried the branch on 3.16.2 of WPR, can see that
1- nothing was mentioned about force-wp-mobile now with smoke test

Error : Warning: The 'force-wp-mobile' plugin could not be found.
Error: No plugins uninstalled.

is not there now but instead Error:, do we log this in any case or just after having error?
2- only 1 scenario failed due to errors in debug.log , probably related to #54
PR npm run test smoke.txt
debug-wp-rocket-is-installed-but-not-activated.log
debug-wp-rocket-is-installed-and-activated.log
debug-enable-all-features.log
debug-roll-back-from-the-tools-tab.log
debug-data-imported-correctly.log
debug-data-exported-correctly-on-latest-version.log

@Khadreal Khadreal requested review from Miraeld and jeawhanlee July 9, 2024 09:54
@Khadreal Khadreal merged commit 3d53029 into trunk Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke test force-wp-mobile plugin error
3 participants