Skip to content

Commit

Permalink
Remove hardcoded url (#66)
Browse files Browse the repository at this point in the history
* Removed hardcoded url

* Revert "Removed hardcoded url"

This reverts commit bedee00.

* Removed hard coded urls
  • Loading branch information
jeawhanlee authored Apr 5, 2024
1 parent 573db34 commit 788a6ba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/features/delay-js.feature
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Feature: No Regression with delayjs script udpate
And visit page '' in mobile view
And expand mobile menu
And I click on link
Then page navigated to the new page 'https://e2e.rocketlabsqa.ovh/about-us'
Then page navigated to the new page 'about-us'

Scenario: Shouldn't cause console error when enabling Delay JS with WPML
When I go to 'wp-admin/plugins.php'
Expand Down
3 changes: 2 additions & 1 deletion src/support/steps/general.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,8 @@ const getConsoleMsg = async (page: Page, url: string): Promise<Array<string>> =>
/**
* Executes the step to assert that page navigation.
*/
Then('page navigated to the new page {string}', async function (this: ICustomWorld, url) {
Then('page navigated to the new page {string}', async function (this: ICustomWorld, path) {
const url = `${WP_BASE_URL}/${path}`;
const regex = new RegExp(url);
await expect(this.page).toHaveURL(regex);
});

0 comments on commit 788a6ba

Please sign in to comment.