Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Launchpad integration to the plugin #33

Merged
merged 17 commits into from
Jul 18, 2024

Conversation

CrochetFeve0251
Copy link
Contributor

Description

Add launchpad integration to RocketCDN.

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

Launchpad core: wp-launchpad/core
Launchpad options: wp-launchpad/framework-options

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@CrochetFeve0251 CrochetFeve0251 changed the base branch from main to develop May 15, 2024 14:02
@CrochetFeve0251 CrochetFeve0251 requested review from a team May 15, 2024 14:02
@CrochetFeve0251 CrochetFeve0251 self-assigned this May 15, 2024
@CrochetFeve0251 CrochetFeve0251 added the enhancement New feature or request label May 15, 2024
@nicomollet
Copy link

There is no vendor or vendor-prefixed in the repo, is this release-ready?

@CrochetFeve0251
Copy link
Contributor Author

There is no vendor or vendor-prefixed in the repo, is this release-ready?

@nicomollet they are added by the CI.

readme.txt Outdated Show resolved Hide resolved
@Mai-Saad Mai-Saad self-requested a review July 5, 2024 06:22
@CrochetFeve0251 CrochetFeve0251 merged commit 7d17034 into develop Jul 18, 2024
5 checks passed
@CrochetFeve0251 CrochetFeve0251 deleted the enhancement/add-launchpad branch July 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants