Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8: Any active plugin in a category returns copy of the original array and throws an error on frontend #9

Merged

Conversation

jeawhanlee
Copy link
Collaborator

@jeawhanlee jeawhanlee commented Oct 25, 2024

Description

This PR fixes the issue of an error notice when the 2nd or last plugin is activated in the category also it fixes the issue where the optimize category is pushed to the last.

Fixes #8

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Technical description

Documentation

In this change, We updated the original array by making reference to it directly and also kept the optimize category at the top for wp rocket by checking if the active plugin is not the main plugin.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@jeawhanlee jeawhanlee added the bug Something isn't working label Oct 25, 2024
@jeawhanlee jeawhanlee self-assigned this Oct 25, 2024
@jeawhanlee jeawhanlee marked this pull request as ready for review October 25, 2024 11:40
@jeawhanlee jeawhanlee requested a review from a team October 25, 2024 11:40
@jeawhanlee jeawhanlee merged commit d50c8b8 into develop Oct 25, 2024
7 checks passed
@jeawhanlee jeawhanlee mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any active plugin in a category returns copy of the original array and throws an error on frontend
3 participants