Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Product_Attributes_Connection_Orderby_Enum with MENU_ORDER #876

Merged

Conversation

alexookah
Copy link
Contributor

@alexookah alexookah commented Jul 16, 2024

This PR adds an enum for the product attributes orderBy enum. Adding the Menu_Order to return objects in the order defined.

Does this close any currently open issues?

#475

Any other comments?

Relevant PR: wp-graphql/wp-graphql#3170

Where has this been tested?

  • WooGraphQL Version: 0.20.0
  • WPGraphQL Version: 1.27.2
  • WordPress Version: 6.6
  • WooCommerce Version: 9.1.2

Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexookah Fix the linter issues.

@alexookah alexookah requested a review from kidunot89 July 24, 2024 22:35
@alexookah
Copy link
Contributor Author

@kidunot89
Lint fixes fixed

@kidunot89 kidunot89 merged commit 1424f57 into wp-graphql:develop Jul 29, 2024
11 of 15 checks passed
@alexookah alexookah deleted the extend_product_attributes_terms branch July 29, 2024 21:16
@kidunot89 kidunot89 added the bugfix Implements bugfix label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants